fix(misc): work on ocp to improve the errors that were missed and better logging

server/services/ocp/controller/labeling/labelProcess.ts

@@ -52,7 +52,7 @@ export const labelingProcess = async ({
         const macId = await getMac(line);
         // filter out the lot for the line
         filteredLot = lots.data.filter(
-            (l: any) => l.MachineID === macId[0].HumanReadableId
+            (l: any) => l.MachineID === macId[0]?.HumanReadableId
         );
 
         if (filteredLot.length === 0) {

server/services/ocp/controller/specialProcesses/dyco/plcConnection.ts

@@ -36,7 +36,7 @@ export const dycoConnect = async () => {
             plcCycle = setInterval(async () => {
                 if (isReading) {
                     createLog(
-                        "warn",
+                        "debug",
                         "dyco",
                         "ocp",
                         "Skipping cycle: previous read still in progress."

server/services/ocp/controller/specialProcesses/dyco/plcTags/strapperFault.ts

@@ -7,6 +7,7 @@ import { createLog } from "../../../../../logger/logger.js";
 export let strapperActive = true;
 export let stapperFaulted = false;
 export let strapperFaultCount = 3; // move to db so we can control it outside the app
+let alreadyAlerted = false;
 
 export const strapperFaults = async (tagData: any) => {
     const { data, error } = await tryCatch(db.select().from(settings));
@@ -15,27 +16,6 @@ export const strapperFaults = async (tagData: any) => {
         return { success: false, message: "Failed to get settings." };
     }
 
-    if (strapperActive) {
-        // monitor strapper
-        //console.log(`Strapper fault is ${strapperError.value}`);
-        if (tagData.value && strapperFaultCount > 0) {
-            // strapper faulted we want to start the trigger to force the check
-            if (!stapperFaulted) {
-                createLog(
-                    "error",
-                    "dyco",
-                    "ocp",
-                    `Strapper errored triggering manual checks will be required for the next ${strapperFaultCount}`
-                );
-            }
-
-            stapperFaulted = true;
-
-            // change move fault count to db....
-            strapperFaultCount = 3;
-        }
-    }
-
     const strapperCheckSetting = data.filter((n) => n.name === "strapperCheck");
 
     if (strapperCheckSetting[0]?.value === "1") {
@@ -46,6 +26,7 @@ export const strapperFaults = async (tagData: any) => {
                 "ocp",
                 `There was a strapper error, remaining pallets to check ${strapperFaultCount}.`
             );
+            alreadyAlerted = true;
             strapperFaultCount = strapperFaultCount - 1;
             return {
                 success: false,
@@ -69,4 +50,25 @@ export const strapperFaults = async (tagData: any) => {
             };
         }
     }
+
+    if (strapperActive) {
+        // monitor strapper
+        //console.log(`Strapper fault is ${strapperError.value}`);
+        if (tagData.value && strapperFaultCount > 0) {
+            // strapper faulted we want to start the trigger to force the check
+            if (!stapperFaulted) {
+                createLog(
+                    "error",
+                    "dyco",
+                    "ocp",
+                    `Strapper errored triggering manual checks will be required for the next ${strapperFaultCount}`
+                );
+            }
+
+            stapperFaulted = true;
+            alreadyAlerted = true;
+            // change move fault count to db....
+            strapperFaultCount = 3;
+        }
+    }
 };

server/services/rfid/route/mgtEvents.ts

@@ -59,7 +59,7 @@ app.openapi(
                 await readTags(reader);
             } else {
                 createLog(
-                    "info",
+                    "debug",
                     "rfid",
                     "rfid",
                     `A new trigger from ${reader} was to soon`