fix(sqlserver): if we already have a connection just return we dont want to try a second time

server/services/sqlServer/prodSqlServer.ts

@@ -11,26 +11,57 @@ let pool: any;
 let connected: boolean = false;
 export const initializeProdPool = async () => {
   if (!installed) {
-        createLog("info", "lst", "sqlProd", "The server was not installed will reconnect in 5 seconds");
+    createLog(
+      "info",
+      "lst",
+      "sqlProd",
+      "The server was not installed will reconnect in 5 seconds"
+    );
     setTimeout(() => {
       initializeProdPool();
     }, 5 * 1000);
 
     return { success: false, message: "The server is not installed." };
   }
-    const dbServer = await db.select().from(settings).where(eq(settings.name, "dbServer"));
+  const dbServer = await db
+    .select()
+    .from(settings)
+    .where(eq(settings.name, "dbServer"));
   const serverUp = await checkHostnamePort(`${dbServer[0].value}:1433`);
 
   if (!serverUp) {
-        createLog("error", "lst", "server", `The sql ${dbServer[0].value} is not reachable`);
+    createLog(
-        return {success: false, message: `The sql ${dbServer[0].value} is not reachable`};
+      "error",
+      "lst",
+      "server",
+      `The sql ${dbServer[0].value} is not reachable`
+    );
+    return {
+      success: false,
+      message: `The sql ${dbServer[0].value} is not reachable`,
+    };
   }
 
   // make sure the server is not set to localhost this will prevent some weird issues later but can be localhost on the dev
-    const serverLoc = await db.select().from(settings).where(eq(settings.name, "dbServer"));
+  const serverLoc = await db
-    if (serverLoc[0].value === "localhost" && process.env.NODE_ENV !== "development") {
+    .select()
-        createLog("error", "lst", "sqlProd", "The server is set to localhost, and you are not in development mode.");
+    .from(settings)
-        return {success: false, message: "The server is set to localhost, and you are not in development mode."};
+    .where(eq(settings.name, "dbServer"));
+  if (
+    serverLoc[0].value === "localhost" &&
+    process.env.NODE_ENV !== "development"
+  ) {
+    createLog(
+      "error",
+      "lst",
+      "sqlProd",
+      "The server is set to localhost, and you are not in development mode."
+    );
+    return {
+      success: false,
+      message:
+        "The server is set to localhost, and you are not in development mode.",
+    };
   }
 
   // if you were restarting from the endpoint you get this lovely error
@@ -42,27 +73,54 @@ export const initializeProdPool = async () => {
     const config = await prodSqlConfig();
     pool = await sql.connect(config!);
 
-        createLog("info", "lst", "sqlProd", `Connected to ${config?.server}, and looking at ${config?.database}`);
+    createLog(
+      "info",
+      "lst",
+      "sqlProd",
+      `Connected to ${config?.server}, and looking at ${config?.database}`
+    );
     connected = true;
-        return {success: true, message: "The sql server connection has been closed"};
+    return {
-    } catch (error) {
+      success: true,
-        createLog("error", "lst", "sqlProd", `${JSON.stringify(error)}, "There was an error connecting to the pool."`);
+      message: "The sql server connection has been closed",
-        throw new Error("There was an error closing the sql connection");
-    }
     };
-
-export const closePool = async () => {
-    try {
-        await pool.close();
-        createLog("info", "lst", "sqlProd", "Connection pool closed");
-        connected = false;
-        return {success: true, message: "The sql server connection has been closed"};
   } catch (error) {
     createLog(
       "error",
       "lst",
       "sqlProd",
-            `${JSON.stringify(error)},  "There was an error closing the sql connection"`
+      `${JSON.stringify(error)}, "There was an error connecting to the pool."`
+    );
+    throw new Error("There was an error closing the sql connection");
+  }
+};
+
+export const closePool = async () => {
+  if (!connected) {
+    createLog(
+      "error",
+      "lst",
+      "sqlProd",
+      "There is no connection a connection."
+    );
+    return { success: false, message: "There is already a connection." };
+  }
+  try {
+    await pool.close();
+    createLog("info", "lst", "sqlProd", "Connection pool closed");
+    connected = false;
+    return {
+      success: true,
+      message: "The sql server connection has been closed",
+    };
+  } catch (error) {
+    createLog(
+      "error",
+      "lst",
+      "sqlProd",
+      `${JSON.stringify(
+        error
+      )},  "There was an error closing the sql connection"`
     );
     throw new Error("There was an error closing the sql connection");
   }
@@ -72,22 +130,44 @@ export async function query(queryToRun: string, name: string) {
   /**
    * Just an extra catch incase someone tried to run a query while we were not connected to the server or sql server
    */
-    const dbServer = await db.select().from(settings).where(eq(settings.name, "dbServer"));
+  const dbServer = await db
+    .select()
+    .from(settings)
+    .where(eq(settings.name, "dbServer"));
   const serverUp = await checkHostnamePort(`${dbServer[0].value}:1433`);
 
   if (!serverUp) {
-        createLog("error", "lst", "server", `The sql ${dbServer[0].value} is not reachable`);
+    createLog(
-        return {success: false, message: `The sql ${dbServer[0].value} is not reachable`};
+      "error",
+      "lst",
+      "server",
+      `The sql ${dbServer[0].value} is not reachable`
+    );
+    return {
+      success: false,
+      message: `The sql ${dbServer[0].value} is not reachable`,
+    };
   }
 
   if (!connected) {
-        createLog("error", "lst", "server", `The sql ${dbServer[0].value} is not connected`);
+    createLog(
-        return {success: false, message: `The sql ${dbServer[0].value} is not not connected`};
+      "error",
+      "lst",
+      "server",
+      `The sql ${dbServer[0].value} is not connected`
+    );
+    return {
+      success: false,
+      message: `The sql ${dbServer[0].value} is not not connected`,
+    };
   }
   /**
    * We no longer need to send over the plant token change as we do it inside the query function.
    */
-    const plantToken = await db.select().from(settings).where(eq(settings.name, "plantToken"));
+  const plantToken = await db
+    .select()
+    .from(settings)
+    .where(eq(settings.name, "plantToken"));
   const query = queryToRun.replaceAll("test1", plantToken[0].value);
 
   try {
@@ -96,12 +176,19 @@ export async function query(queryToRun: string, name: string) {
     return result.recordset;
   } catch (error: any) {
     if (error.code === "ETIMEOUT") {
-            createLog("error", "lst", "sqlProd", `${JSON.stringify(error)}, ${name} did not run due to a timeout.`);
+      createLog(
+        "error",
+        "lst",
+        "sqlProd",
+        `${JSON.stringify(error)}, ${name} did not run due to a timeout.`
+      );
       throw new Error(`${name} query did not run due to a timeout.`);
     }
 
     if (error.code === "EREQUEST") {
-            throw new Error(`${name} encoutnered an error ${error.originalError.info.message}`);
+      throw new Error(
+        `${name} encoutnered an error ${error.originalError.info.message}`
+      );
     }
 
     //console.log(error.originalError.info.message);