fix(lots errors): fixes to prevent crashes when sql server not connected

server/services/ocp/controller/lots/lots.ts

@@ -11,18 +11,10 @@ export const getLots = async () => {
         return {
             success: false,
             message: "There was an error getting the lots",
-            data: lotError,
+            data: [],
         };
     }
 
-    // if (!lotInfo.data.success) {
-    //     return {
-    //         success: false,
-    //         message: "There was an error getting the lots",
-    //         data: lotInfo.data.message,
-    //     };
-    // }
-
     return {
         success: true,
         message: "Current active lots that are technically released.",

server/services/ocp/controller/printers/updatePrinters.ts

@@ -25,7 +25,7 @@ export const updatePrinters = async () => {
         })
     );
 
-    if (prodError) {
+    if (prodError || prodPrinters?.data.length > 10000) {
         //console.log(prodError);
         return {
             success: false,
@@ -35,7 +35,7 @@ export const updatePrinters = async () => {
     }
 
     // do the printer update into our db
-    const prodPrinterInfo = prodPrinters.data;
+    const prodPrinterInfo = prodPrinters?.data;
 
     for (let i = 0; i < prodPrinterInfo.length; i++) {
         const printerStuff: any = {

server/services/ocp/routes/lots/getLots.ts

@@ -2,7 +2,6 @@
 import { createRoute, OpenAPIHono, z } from "@hono/zod-openapi";
 import { responses } from "../../../../globalUtils/routeDefs/responses.js";
 import { tryCatch } from "../../../../globalUtils/tryCatch.js";
-import { getPrinters } from "../../controller/printers/getPrinters.js";
 import { getLots } from "../../controller/lots/lots.js";
 
 const app = new OpenAPIHono({ strict: false });
@@ -15,7 +14,7 @@ app.openapi(
         path: "/getlots",
         responses: responses(),
     }),
-    async (c) => {
+    async (c: any) => {
         const { data: lotData, error: lotError } = await tryCatch(getLots());
 
         if (lotError) {
@@ -26,9 +25,9 @@ app.openapi(
         }
 
         return c.json({
-            success: lotData.success,
+            success: lotData?.success,
-            message: lotData.message,
+            message: lotData?.message,
-            data: lotData.data,
+            data: lotData?.data,
         });
     }
 );

server/services/ocp/utils/checkAssignments.ts

@@ -18,6 +18,20 @@ export const assignedPrinters = async () => {
             data: lotError,
         };
     }
+
+    if (l.data.length === 0 && !l.data.sucess) {
+        createLog(
+            "error",
+            "lst",
+            "ocp",
+            `There was an error getting the lots: ${l?.message}`
+        );
+        return {
+            success: false,
+            message: "Error getting lots",
+            data: [],
+        };
+    }
     const { data: print, error: printerError } = await tryCatch(getPrinters());
 
     if (printerError) {
@@ -29,17 +43,11 @@ export const assignedPrinters = async () => {
     }
 
     const printers: any = print.data ?? [];
-    const lots: any = l.data.length === 0 ? [] : l.data;
+    const lots: any = l?.data.length === 0 ? null : l?.data;
+
+    //console.log(lots);
 
-    if (!lots) {
-        createLog(
-            "error",
-            "lst",
-            "ocp",
-            `There was an error getting the lots: ${lots.message}`
-        );
     return;
-    }
     for (let i = 0; i < printers.length; i++) {
         // is the printer assinged in alplalabel online?
         const assigned = lots?.filter(

server/services/sqlServer/prodSqlServer.ts

@@ -39,6 +39,7 @@ export const initializeProdPool = async () => {
         return {
             success: false,
             message: `The sql ${dbServer[0].value} is not reachable`,
+            data: [],
         };
     }
 
@@ -61,6 +62,7 @@ export const initializeProdPool = async () => {
             success: false,
             message:
                 "The server is set to localhost, and you are not in development mode.",
+            data: [],
         };
     }
 
@@ -89,7 +91,9 @@ export const initializeProdPool = async () => {
             "error",
             "lst",
             "sqlProd",
-      `${JSON.stringify(error)}, "There was an error connecting to the pool."`
+            `${JSON.stringify(
+                error
+            )}, "There was an error connecting to the pool."`
         );
         throw new Error("There was an error closing the sql connection");
     }
@@ -146,6 +150,7 @@ export async function query(queryToRun: string, name: string) {
         return {
             success: false,
             message: `The sql ${dbServer[0].value} is not reachable`,
+            data: [],
         };
     }
 
@@ -180,7 +185,9 @@ export async function query(queryToRun: string, name: string) {
                 "error",
                 "lst",
                 "sqlProd",
-        `${JSON.stringify(error)}, ${name} did not run due to a timeout.`
+                `${JSON.stringify(
+                    error
+                )}, ${name} did not run due to a timeout.`
             );
             throw new Error(`${name} query did not run due to a timeout.`);
         }